Skip to content

feat: add option to toggle on FEC in minigraph (#17295)#233

Merged
yejianquan merged 1 commit into202405from
austinpham/azure/conflict/202405-17295-conflic-resolve
Apr 29, 2025
Merged

feat: add option to toggle on FEC in minigraph (#17295)#233
yejianquan merged 1 commit into202405from
austinpham/azure/conflict/202405-17295-conflic-resolve

Conversation

@auspham
Copy link
Member

@auspham auspham commented Apr 28, 2025

Conflict fix sonic-net/sonic-mgmt#17295

Description of PR
Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287

Approach
What is the motivation for this PR?
When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC.

To use it, modify the links file. For example suppose we have the original _links.csv:

StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ...
Let's say we want to force disable FEC on Ethernet24:

StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything

How did you do it?
Add attribute in minigraph to disable at deploy-mg phase

How did you verify/test it?
T2 physical testbed

Description of PR
Summary: Add option to toggle on FEC for minigraph in ixia topo
Fixes # (issue) 31623287

Approach
What is the motivation for this PR?
When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC.

To use it, modify the links file. For example suppose we have the original _links.csv:

StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg
str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on
str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on
str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on
str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on
str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on
str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on
str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on
...
Let's say we want to force disable FEC on Ethernet24:

StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable
str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on
str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on
str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on
str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on
str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on
str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on
str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true
Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything

How did you do it?
Add attribute in minigraph to disable at deploy-mg phase

How did you verify/test it?
T2 physical testbed

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@yejianquan yejianquan merged commit 65b384f into 202405 Apr 29, 2025
3 checks passed
@bingwang-ms bingwang-ms deleted the austinpham/azure/conflict/202405-17295-conflic-resolve branch May 29, 2025 00:55
@bingwang-ms bingwang-ms restored the austinpham/azure/conflict/202405-17295-conflic-resolve branch May 29, 2025 00:55
@auspham auspham deleted the austinpham/azure/conflict/202405-17295-conflic-resolve branch May 29, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants